Sitelet https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/342
Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Operation IDs are being duplicated under load #342

Description

I notice that, under load, my ASP.NET Core website generates request telemetry with duplicate Operation IDs.

It appears that HostingDiagnosticListener isn't written with multiple simultaneous requests in mind.
In particular, this.client.Context.Operation.Id gets overwritten by each new request (line 44)
(Also beginRequestTimestamp)

Rather that setting the Operation ID in the client's context (which is like setting it globally), I believe it should be set in the RequestTelemetry object that is added to HttpContext.Features
One would think that the timestamp could also be recorded in the RequestTelemetry object (indeed it already has fields for recording start time, so it's odd that it's not initialized here)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions