-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtest_json_renderer.cpp
More file actions
168 lines (141 loc) · 6.33 KB
/
Copy pathtest_json_renderer.cpp
File metadata and controls
168 lines (141 loc) · 6.33 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
#include <gtest/gtest.h>
#include "sysmon/json_renderer.hpp"
#include <sstream>
#include <string>
namespace {
/// A minimal structural check: balanced braces/brackets outside string
/// literals, and no stray commas before a closing token. This catches the
/// mistakes a hand-rolled serialiser actually makes, without pulling in a JSON
/// parser dependency.
bool structurally_valid(const std::string& json) {
int depth = 0;
bool in_string = false;
bool escaped = false;
char last_significant = '\0';
for (char c : json) {
if (in_string) {
if (escaped) escaped = false;
else if (c == '\\') escaped = true;
else if (c == '"') in_string = false;
continue;
}
switch (c) {
case '"': in_string = true; break;
case '{': case '[': ++depth; break;
case '}': case ']':
--depth;
if (depth < 0) return false;
if (last_significant == ',') return false; // trailing comma
break;
default: break;
}
if (c != ' ' && c != '\n' && c != '\t') last_significant = c;
}
return depth == 0 && !in_string;
}
Snapshot make_snapshot() {
Snapshot snap;
snap.system.hostname = "test-host";
snap.system.os = "Test OS";
snap.cpu.model = "Test CPU";
snap.cpu.logical_cores = 4;
snap.cpu.flags = {"sse2", "avx2"};
snap.cpu.per_core.resize(2);
snap.memory.ram_total_bytes = 1024;
snap.disks.push_back(DiskStats{});
snap.disks.back().mountpoint = "/";
snap.network.push_back(NetworkStats{});
snap.network.back().name = "eth0";
snap.net_global.dns_servers = {"1.1.1.1", "8.8.8.8"};
snap.processes.push_back(ProcessStats{});
snap.processes.back().name = "init";
snap.connections.push_back(NetConnectionStats{});
return snap;
}
} // namespace
TEST(JsonRendererTest, ProducesStructurallyValidJson) {
JsonRenderer renderer;
const std::string json = renderer.to_string(make_snapshot(), Config::defaults());
EXPECT_TRUE(structurally_valid(json)) << json;
EXPECT_NE(json.find("\"hostname\": \"test-host\""), std::string::npos) << json;
}
TEST(JsonRendererTest, CompactModeIsAlsoValid) {
JsonRenderer renderer;
renderer.set_pretty(false);
const std::string json = renderer.to_string(make_snapshot(), Config::defaults());
EXPECT_TRUE(structurally_valid(json)) << json;
EXPECT_EQ(json.find('\n'), json.size() - 1) << "compact output must be one line";
}
TEST(JsonRendererTest, ArraysHoldBareValuesNotKeyedPairs) {
JsonRenderer renderer;
const std::string json = renderer.to_string(make_snapshot(), Config::defaults());
// A string array element must never be emitted as `"": "value"`.
EXPECT_EQ(json.find("\"\": "), std::string::npos) << json;
EXPECT_NE(json.find("\"sse2\""), std::string::npos) << json;
EXPECT_NE(json.find("\"1.1.1.1\""), std::string::npos) << json;
}
TEST(JsonRendererTest, UnmeasurableValuesBecomeNullNotZero) {
Snapshot snap = make_snapshot();
snap.cpu.frequency_mhz = std::nullopt;
snap.cpu.temperature_celsius = std::nullopt;
JsonRenderer renderer;
const std::string json = renderer.to_string(snap, Config::defaults());
EXPECT_NE(json.find("\"frequency_mhz\": null"), std::string::npos) << json;
EXPECT_NE(json.find("\"temperature_celsius\": null"), std::string::npos) << json;
// A measured value is still a number.
snap.cpu.frequency_mhz = 3200.0;
const std::string with_value = renderer.to_string(snap, Config::defaults());
EXPECT_NE(with_value.find("\"frequency_mhz\": 3200.0"), std::string::npos) << with_value;
}
TEST(JsonRendererTest, EscapesQuotesAndBackslashesInNames) {
Snapshot snap = make_snapshot();
snap.processes.back().name = R"(weird "name" \ here)";
snap.disks.back().mountpoint = R"(C:\Program Files)";
JsonRenderer renderer;
const std::string json = renderer.to_string(snap, Config::defaults());
EXPECT_TRUE(structurally_valid(json)) << json;
EXPECT_NE(json.find(R"(weird \"name\" \\ here)"), std::string::npos) << json;
EXPECT_NE(json.find(R"(C:\\Program Files)"), std::string::npos) << json;
}
TEST(JsonRendererTest, EmptySnapshotStillProducesValidDocument) {
JsonRenderer renderer;
const std::string json = renderer.to_string(Snapshot{}, Config::defaults());
EXPECT_TRUE(structurally_valid(json)) << json;
EXPECT_NE(json.find("\"processes\""), std::string::npos);
}
TEST(JsonRendererTest, PerProcessBandwidthIsNullWhenUnattributed) {
// A process whose network use could not be attributed must be null, not 0:
// "sent nothing" and "no counter exists for this platform" are different
// answers, and only one of them is a measurement.
Snapshot snap = make_snapshot();
ProcessStats& p = snap.processes.back();
p.rx_bytes_per_sec = std::nullopt;
p.tx_bytes_per_sec = std::nullopt;
p.socket_count = std::nullopt;
p.io_read_bytes_total = std::nullopt;
JsonRenderer renderer;
const std::string json = renderer.to_string(snap, Config::defaults());
EXPECT_TRUE(structurally_valid(json)) << json;
for (const char* key : {"rx_bytes_per_sec", "tx_bytes_per_sec",
"socket_count", "io_read_bytes_total"}) {
const std::string needle = std::string("\"") + key + "\": null";
EXPECT_NE(json.find(needle), std::string::npos) << key << " was not null:\n" << json;
}
// A measured value must survive as a number.
p.tx_bytes_per_sec = 2048.0;
p.socket_count = 3u;
const std::string measured = renderer.to_string(snap, Config::defaults());
EXPECT_NE(measured.find("\"tx_bytes_per_sec\": 2048.0"), std::string::npos) << measured;
EXPECT_NE(measured.find("\"socket_count\": 3"), std::string::npos) << measured;
}
TEST(JsonRendererTest, DetailLevelDoesNotChangeTheExport) {
// --json is a data export, not a view: the density that shapes the
// dashboard must not decide which fields a consumer receives.
const Snapshot snap = make_snapshot();
JsonRenderer renderer;
Config compact = Config::defaults();
compact.detail_level = DetailLevel::Compact;
Config full = Config::defaults();
full.detail_level = DetailLevel::Full;
EXPECT_EQ(renderer.to_string(snap, compact), renderer.to_string(snap, full));
}