Sitelet https://github.com/KrailOrg/krail/commit/5d4ddc9df57d30ccc1cd73323806b7ff9f1ff6af
Skip to content

Commit 5d4ddc9

Browse files
author
David Sowerby
committed
NavigationStateExt.node is now not nullable. See #711
1 parent fab103e commit 5d4ddc9

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

‎src/main/java/uk/q3c/krail/core/navigate/DefaultNavigator.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,10 @@ public void error(Throwable error) {
394394
ErrorView view = viewFactory.get(ErrorView.class);
395395
view.setError(error);
396396
UserSitemapNode node = userSitemap.nodeFor(navigationState);
397-
changeView(view, new NavigationStateExt(previousNavigationState, navigationState, null));
397+
if (node == null) {
398+
node = userSitemap.standardPageNode(StandardPageKey.Log_Out); // TODO there should be a node for error https://github.com/KrailOrg/krail/issues/711
399+
}
400+
changeView(view, new NavigationStateExt(previousNavigationState, navigationState, node));
398401
}
399402

400403
/**

‎src/main/kotlin/uk/q3c/krail/core/form/Form.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,11 @@ class DefaultForm @Inject constructor(
8383
}
8484

8585
override fun doBuild() {
86-
val viewConfigurationClass = navigationStateExt.node?.masterNode?.viewConfiguration
86+
val viewConfigurationClass = navigationStateExt.node.masterNode.viewConfiguration
8787
val formConfiguration =
8888
if (FormConfiguration::class.java.isAssignableFrom(viewConfigurationClass)) {
8989
try {
90-
viewConfigurationClass?.newInstance() as FormConfiguration
90+
viewConfigurationClass.newInstance() as FormConfiguration
9191
} catch (e: Exception) {
9292
log.error("Failed to set form configuration", e)
9393
EmptyFormConfiguration()

‎src/main/kotlin/uk/q3c/krail/core/view/NavigationStateExt.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ import java.io.Serializable
77
/**
88
* Created by David Sowerby on 12 Jun 2018
99
*/
10-
data class NavigationStateExt(val from: NavigationState?, val to: NavigationState, val node: UserSitemapNode?) : Serializable
10+
data class NavigationStateExt(val from: NavigationState?, val to: NavigationState, val node: UserSitemapNode) : Serializable

0 commit comments

Comments
 (0)