Sitelet https://github.com/Galoretka/sp1/commit/64ba1ac29bd0757067fba4be737f1c729adbc564
Skip to content

Commit 64ba1ac

Browse files
authored
fix: [SP1-571] remove eprintln in SDK (succinctlabs#2495)
1 parent a6e1c5f commit 64ba1ac

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

‎.github/actions/setup/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ runs:
117117
run: docker buildx version
118118

119119
- name: Set up Docker
120-
uses: crazy-max/ghaction-setup-docker@v3
120+
uses: crazy-max/ghaction-setup-docker@v4
121121

122122
- name: Set up Docker Buildx
123123
uses: docker/setup-buildx-action@v3

‎crates/sdk/src/install.rs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
55
use cfg_if::cfg_if;
66
use std::path::PathBuf;
7+
use tracing::info;
78

89
#[cfg(any(feature = "network", feature = "network"))]
910
use {
@@ -53,15 +54,15 @@ pub fn try_install_circuit_artifacts(artifacts_type: &str) -> PathBuf {
5354
};
5455

5556
if build_dir.exists() {
56-
eprintln!(
57+
info!(
5758
"[sp1] {} circuit artifacts already seem to exist at {}. if you want to re-download them, delete the directory",
5859
artifacts_type,
5960
build_dir.display()
6061
);
6162
} else {
6263
cfg_if! {
6364
if #[cfg(any(feature = "network", feature = "network"))] {
64-
eprintln!(
65+
info!(
6566
"[sp1] {} circuit artifacts for version {} do not exist at {}. downloading...",
6667
artifacts_type,
6768
SP1_CIRCUIT_VERSION,
@@ -105,7 +106,7 @@ pub fn install_circuit_artifacts(build_dir: PathBuf, artifacts_type: &str) {
105106
.expect("failed to extract tarball");
106107
res.wait().unwrap();
107108

108-
eprintln!("[sp1] downloaded {} to {:?}", download_url, build_dir.to_str().unwrap(),);
109+
info!("[sp1] downloaded {} to {:?}", download_url, build_dir.to_str().unwrap(),);
109110
}
110111

111112
/// Download the file with a progress bar that indicates the progress.

‎crates/sdk/src/network/prove.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -653,8 +653,8 @@ impl NetworkProveBuilder<'_> {
653653

654654
// Check for deprecated environment variable.
655655
if let Ok(val) = std::env::var("SKIP_SIMULATION") {
656-
eprintln!(
657-
"Warning: SKIP_SIMULATION environment variable is deprecated. Please use .skip_simulation() instead."
656+
tracing::warn!(
657+
"SKIP_SIMULATION environment variable is deprecated. Please use .skip_simulation() instead."
658658
);
659659
self.skip_simulation = matches!(val.to_lowercase().as_str(), "true" | "1");
660660
}

‎crates/sdk/src/utils.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ pub(crate) fn sp1_dump(elf: &[u8], stdin: &SP1Stdin) {
5050
let stdin = bincode::serialize(&stdin).unwrap();
5151
std::fs::write("stdin.bin", stdin.clone()).unwrap();
5252

53-
eprintln!("Dumped program.bin and stdin.bin.");
53+
tracing::info!("Dumped program.bin and stdin.bin.");
5454
// Exit with the success status.
5555
std::process::exit(0);
5656
}

0 commit comments

Comments
 (0)