Sitelet https://github.com/pre-commit/pre-commit/pull/2332
Skip to content

Handling multiple outputs from dotnet pack - #2332

Merged
asottile merged 1 commit into
pre-commit:mainfrom
WallucePinkham:main
Apr 7, 2022
Merged

asottile merged 1 commit into
pre-commit:mainfrom
WallucePinkham:main

Conversation

@WallucePinkham

Copy link
Copy Markdown

This will allow multiple outputs from the dotnet pack command. This will allow a single dotnet repository to contain multiple hooks.

@asottile

asottile commented Apr 6, 2022

Copy link
Copy Markdown
Member

please add a test demonstrating your change -- you can find similar dotnet tests in tests/repository_test.py

@WallucePinkham
WallucePinkham marked this pull request as draft April 7, 2022 14:17
@WallucePinkham
WallucePinkham marked this pull request as ready for review April 7, 2022 14:25
@WallucePinkham

Copy link
Copy Markdown
Author

Seems like the build-agent doesn't support dotnet 6.0

@WallucePinkham

Copy link
Copy Markdown
Author

Tests added

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
asottile merged commit ecd7363 into pre-commit:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants