stringify: fix arrayFormat comma with empty array/objects - #350
Conversation
|
Why did you open a second PR? That creates a permanent pollution in the repo refs that can never be removed. Please never ever make a duplicate PR. |
|
@daggerjames hey, sorry for the delay here :-) I've rebased this; the first commit is awesome and good to go; for the second one, 3 of your new tests are failing - and it seems like the tests are correct. Can you take a look? |
|
fixed all tests. Seems logical error with previous approach. Thanks~ |
ljharb
left a comment
There was a problem hiding this comment.
Not stoked on the "use an object as a sentinel key" but it seems straightforward enough, and tests pass.
Thanks, and sorry for the repeated delays :-)
|
Hi @ljharb, sorry to bother you, but were these changes published to npm? I can still reproduce the original behavior from the latest published version. See this failed test (extracted from this pull request) |
|
No; this hasn’t been published yet. |
Fixed #310
continued from PR #317