馃悶 bug report
Affected Package
The issue is caused by package @angular/service-worker
Is this a regression?
No, I don't think so,
Description
The Service Worker registration logs an error in the console when the it fails. I think that's confusing and it would be better to use the ErrorHandler which other parts of Angular use. That way Angular users could handle the error themselves.
馃敩 Minimal Reproduction
As far as I know there is not really an easy way to reproduce this besides deploying a broken app. I hope it's okay to point to the source instead.
|
navigator.serviceWorker.register(script, {scope: options.scope}) |
|
.catch(err => console.error('Service worker registration failed with:', err)))); |
This is where the Service Worker gets registered and possible errors get logged to the console directly.
馃敟 Exception or Error
馃實 Your Environment
Angular Version:
Angular CLI: 11.0.2
Node: 12.20.0
OS: darwin x64
Angular: 11.0.2
... animations, cli, common, compiler, compiler-cli, core
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker
Ivy Workspace:
Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1100.2
@angular-devkit/build-angular 0.1100.2
@angular-devkit/core 11.0.2
@angular-devkit/schematics 11.0.2
@schematics/angular 11.0.2
@schematics/update 0.1100.2
rxjs 6.6.3
typescript 4.0.5
Anything else relevant?
I would be happy to create a PR for fixing this. Please let me know if I should do so.
馃悶 bug report
Affected Package
The issue is caused by package @angular/service-workerIs this a regression?
No, I don't think so,
Description
The Service Worker registration logs an error in the console when the it fails. I think that's confusing and it would be better to use the ErrorHandler which other parts of Angular use. That way Angular users could handle the error themselves.
馃敩 Minimal Reproduction
As far as I know there is not really an easy way to reproduce this besides deploying a broken app. I hope it's okay to point to the source instead.
angular/packages/service-worker/src/module.ts
Lines 132 to 133 in 11cd37f
This is where the Service Worker gets registered and possible errors get logged to the console directly.
馃敟 Exception or Error
馃實 Your Environment
Angular Version:
Anything else relevant?
I would be happy to create a PR for fixing this. Please let me know if I should do so.